Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Trigger pop logic when you replace back button with icon #12320

Merged
merged 6 commits into from
Oct 20, 2020
Merged

Trigger pop logic when you replace back button with icon #12320

merged 6 commits into from
Oct 20, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Oct 1, 2020 •
edited
Loading

Description of Change

When replacing the back button with your own image [Export("navigationBar:shouldPopItem:")] no longer fires on the UINavigationController so we need to trigger it as part of our own logic

Issues Resolved

Platforms Affected

  • iOS

Testing Procedure

  • ui test included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Oct 1, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Oct 1, 2020
@PureWeen PureWeen changed the base branch from 4.8.0 to 5.0.0 October 3, 2020 13:24
@PureWeen PureWeen removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Oct 3, 2020
@jsuarezruiz jsuarezruiz mentioned this pull request Oct 7, 2020
Open
@PureWeen
Copy link
Contributor Author

UI Test failures are unrelated

@PureWeen PureWeen mentioned this pull request Oct 18, 2020
Closed
pictos
pictos approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PureWeen PureWeen merged commit e5dfba1 into 5.0.0 Oct 20, 2020
@PureWeen PureWeen deleted the fix_12126 branch October 20, 2020 14:15
@samhouts samhouts modified the milestone: 5.0.0 Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts left review comments

@pictos pictos pictos approved these changes

Assignees
No one assigned
Labels
a/shell 🐚 a/tabbedpage blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. hacktoberfest 🍻 hacktoberfest-accepted p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
5.0.0
3 participants
@PureWeen @samhouts @pictos