Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core,iOS,Android] Remove experimental flags Carousel, Swipe, Shapes, Brush #12068

Merged
merged 4 commits into from
Sep 10, 2020

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Sep 9, 2020

Description of Change

Remove other Experimental flags Brushes, Shapes, SwipeView, CarouselView, DragAndDrop for 5.0

Issues Resolved

  • none

API Changes

Removed:
ExperimentalFlags.cs

	internal const string CarouselViewExperimental = "CarouselView_Experimental";
	internal const string SwipeViewExperimental = "SwipeView_Experimental";
	internal const string ShapesExperimental = "Shapes_Experimental";
	internal const string BrushExperimental = "Brush_Experimental";
	internal const string DragAndDropExperimental = "DragAndDrop_Experimental";

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Tests should still pass

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho rmarinho changed the title [Core,iOS,Android] Remove experimental flags Carrousel,Swipe,Shapes,B… [Core,iOS,Android] Remove experimental flags Carousel, Swipe, Shapes, Brush Sep 9, 2020
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look nice, I have searched to see if there was something pending and everything seems correct, just fix the conflicts.

@rmarinho rmarinho merged commit 1882b5d into 5.0.0 Sep 10, 2020
@rmarinho rmarinho deleted the remove-experimental-flags branch September 10, 2020 11:59
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Sep 13, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants