Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Export animationControllerForOperation to fix hot restart #11370

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Export animationControllerForOperation to fix hot restart #11370

merged 1 commit into from
Jul 13, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jul 8, 2020

Description of Change

The addition of the following override
https://github.com/xamarin/Xamarin.Forms/pull/9237/files#diff-8222d0783ad0aa5666a6d9d008a474b6R109

Is triggering a mono interpreter bug that causes hot restart to crash when navigating on shell

Issues Resolved

Platforms Affected

  • iOS

Testing Procedure

  • download the nuget, create a xamarin forms shell template, install this nuget, verify hot restart works

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added p/iOS 🍎 a/shell 🐚 4.6.0 regression on 4.6.0 a/navigation external-hotrestart i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression t/bug 🐛 labels Jul 8, 2020
@samhouts samhouts self-requested a review July 8, 2020 23:06
@samhouts samhouts self-assigned this Jul 8, 2020
@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jul 13, 2020
@samhouts samhouts merged commit e66db0b into 4.6.0 Jul 13, 2020
@samhouts samhouts deleted the fix_10519 branch July 13, 2020 22:32
@samhouts samhouts modified the milestones: 4.8.0, 4.6.0 Jul 14, 2020
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@samhouts samhouts samhouts approved these changes

Assignees

@jsuarezruiz jsuarezruiz

@samhouts samhouts

Labels
4.6.0 regression on 4.6.0 a/navigation a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. external-hotrestart i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @jsuarezruiz @samhouts