This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Core] Invoke Clicked event tapping SwipeItems #11298
Merged
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
it's very disturbing to have different patterns for event handlers and commands, depending on the type.
MenuItem.OnClicked DOES NOT fire the Command, but SwipeItem.OnInvoked does it.
I would say that a OnXXXd method should trigger both the Command and the event (otherwise, hey, what's the point?), but I might miss something, or this could be a breaking change...
| @@ -29,6 +29,7 @@ public void OnInvoked() | |||
| if (Command != null && Command.CanExecute(CommandParameter)) | |||
There was a problem hiding this comment.
while you're at it, OnInvoked could be an explicit interface implementation
samhouts
approved these changes
Jul 30, 2020
samhouts
requested review from
StephaneDelcroix
and removed request for
StephaneDelcroix
samhouts
added
the
retarget-branch-required
samhouts
removed
the
retarget-branch-required
myroot
pushed a commit
to myroot/Xamarin.Forms
that referenced
this pull request
Aug 19, 2020
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes xamarin#11286
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes xamarin#11286
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes xamarin#11286
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
SwipeItem has its own
Invokedevent but inherits fromIMenuItem. Inheriting from IMenuItem it also has aClickedevent that was not being invoked when tapping the SwipeItem. This PR fixes this issue.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 11286. Swipe to the right and tap the SwipeItem. If the text below the SwipeView is updated, the test has passed.
PR Checklist