This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Fix crash PopAsync in CollectionView SelectionChanged #11160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug 🐛
p/UWP
i/high
lindexi
reviewed
Jun 23, 2020
Xamarin.Forms.Platform.UAP/CollectionView/SelectableItemsViewRenderer.cs
Show resolved
Hide resolved
|
@jsuarezruiz I don't understand what this fix actually does - do we still need this, or has it been addressed in another PR? |
hartez
suggested changes
Jun 26, 2020
Xamarin.Forms.Platform.UAP/CollectionView/SelectableItemsViewRenderer.cs
Show resolved
Hide resolved
samhouts
added
the
DO-NOT-MERGE-!!! 🛑
jsuarezruiz
removed
the
DO-NOT-MERGE-!!! 🛑
jsuarezruiz
force-pushed
the
fix-11090
branch
from
cc5c8d9
to
4c3b739
Compare
rmarinho
added
the
blocker
hartez
approved these changes
Nov 19, 2020
mattleibow
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash PopAsync in ColllectionView SelectionChanged on UWP.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
Crash
After
Testing Procedure
Launch Core Gallery and navigate to the issue 11090. Press the button to navigate to a new page, and after navigate, select an item from the CollectionView. If navigate back without exceptions, the test has passed.
PR Checklist