Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix Frame IsClippedToBounds issue #11129

Merged
merged 5 commits into from
Jul 6, 2020
Merged

[iOS] Fix Frame IsClippedToBounds issue #11129

merged 5 commits into from
Jul 6, 2020

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 19, 2020 •
edited
Loading

Description of Change

Fix Frame IsClippedToBounds issue on iOS.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix11120

(The gif quality is low to keep a small size)

Testing Procedure

Launch Core Gallery and navigate to issue 11120. Toggle the CheckBox to use or not IsClippedToBounds in the Frame. If using IsClippedToBounds clip the buttons, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added p/iOS ?? i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/iOS 🍎 and removed p/iOS ?? labels Jun 20, 2020
@samhouts samhouts requested review from hartez and samhouts June 23, 2020 22:52
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jun 30, 2020
@azapatac
Copy link

azapatac commented Jul 1, 2020

When will you publish this solution?

@samhouts samhouts added the 4.6.0 regression on 4.6.0 label Jul 1, 2020
@hartez hartez added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jul 1, 2020
@jsuarezruiz jsuarezruiz mentioned this pull request Jul 2, 2020
Closed
@jsuarezruiz
Copy link
Contributor Author

Added sample to test the issue 11291.
Issue11291

@jsuarezruiz jsuarezruiz mentioned this pull request Jul 3, 2020
Closed
@hartez hartez removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jul 6, 2020
@hartez hartez merged commit 816e1c8 into 4.7.0 Jul 6, 2020
@hartez hartez deleted the fix-11120 branch July 6, 2020 14:37
@samhouts samhouts mentioned this pull request Jul 13, 2020
Closed
@samhouts samhouts modified the milestones: 4.8.0, 4.7.0 Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@hartez hartez hartez approved these changes

@samhouts samhouts samhouts approved these changes

Assignees

@hartez hartez

@samhouts samhouts

Labels
4.6.0 regression on 4.6.0 a/collectionview a/frame a/shell 🐚 a/visual a/Xaml </> approved Has two approvals, no pending reviews, and no changes requested ControlGallery i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression p/Android p/gtk p/iOS 🍎 p/macOS p/Tizen p/UWP p/WPF t/bug 🐛
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jsuarezruiz @azapatac @StephaneDelcroix @hartez @samhouts