[Bug] MediaElement Disposing exception when MainPage is changed on iOS #9525

StevenGranados · 2020-02-11T16:43:32Z

Description

=================================================================
Native Crash Reporting

Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.

=================================================================
Native stacktrace:

0x10dbcd815 - /Users/macdevdaden/Library/Developer/CoreSimulator/Devices/86CB2D85-7D2A-4118-9F55-58CD6F1C6CB3/data/Containers/Bundle/Application/D6BE2062-65DD-4159-B862-D02C3AACE324/ChatUIXForms.iOS.app/ChatUIXForms.iOS : mono_dump_native_crash_info
0x10dbc1905 - /Users/macdevdaden/Library/Developer/CoreSimulator/Devices/86CB2D85-7D2A-4118-9F55-58CD6F1C6CB3/data/Containers/Bundle/Application/D6BE2062-65DD-4159-B862-D02C3AACE324/ChatUIXForms.iOS.app/ChatUIXForms.iOS : mono_handle_native_crash
0x10dbd4aa8 - /Users/macdevdaden/Library/Developer/CoreSimulator/Devices/86CB2D85-7D2A-4118-9F55-58CD6F1C6CB3/data/Containers/Bundle/Application/D6BE2062-65DD-4159-B862-D02C3AACE324/ChatUIXForms.iOS.app/ChatUIXForms.iOS : mono_sigsegv_signal_handler_debug
0x7fff52457b5d - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/usr/lib/system/libsystem_platform.dylib : _sigtramp
0x1f02d01e02bc1e02 - Unknown
0x7fff25723833 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/Foundation.framework/Foundation : NSKeyValueWillChangeWithPerThreadPendingNotifications
0x7fff2093846d - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/AVFoundation.framework/AVFoundation : -[AVPlayer setRate:withVolumeRampDuration:playImmediately:rateChangeReason:]
0x7fff20938834 - /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/AVFoundation.framework/AVFoundation : -[AVPlayer setRate:]
0x10de39319 - /Users/macdevdaden/Library/Developer/CoreSimulator/Devices/86CB2D85-7D2A-4118-9F55-58CD6F1C6CB3/data/Containers/Bundle/Application/D6BE2062-65DD-4159-B862-D02C3AACE324/ChatUIXForms.iOS.app/ChatUIXForms.iOS : xamarin_dyn_objc_msgSend
0x114eefd3a - Unknown

=================================================================
Basic Fault Address Reporting

Memory around native instruction pointer (0x7fff513fa890):0x7fff513fa880 08 5b 41 5e 41 5f 5d c3 48 85 ff 7e 09 48 8b 07 .[A^A_].H..~.H..
0x7fff513fa890 8a 40 1c 24 01 c3 31 c0 c3 48 85 ff 74 12 78 18 .@.$..1..H..t.x.
0x7fff513fa8a0 48 8b 07 48 85 c0 74 08 48 89 c7 e9 dc c7 00 00 H..H..t.H.......
0x7fff513fa8b0
48 8d 05 6c 09 02 00 c3 48 89 f8 48 c1 e8 3c 48 H..l....H..H..<H

=================================================================
Managed Stacktrace:

  at <unknown> <0xffffffff>
  at ObjCRuntime.Messaging:void_objc_msgSend <0x000e9>
  at AVFoundation.AVPlayer:Pause <0x00122>
  at Xamarin.Forms.Platform.iOS.MediaElementRenderer:Dispose <0x00253>
  at Foundation.NSObject:Dispose <0x00074>
  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x002c5>
  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x00071>
  at Xamarin.Forms.Platform.iOS.VisualElementRenderer`1:Dispose <0x0024a>
  at Foundation.NSObject:Dispose <0x00074>
  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x002c5>
  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x00071>
  at Xamarin.Forms.Platform.iOS.VisualElementRenderer`1:Dispose <0x0024a>
  at Foundation.NSObject:Dispose <0x00074>
  at Xamarin.Forms.Platform

.iOS.VisualElementPackager:Dispose <0x002c5>
at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x00071>
at Xamarin.Forms.Platform.iOS.VisualElementRenderer`1:Dispose <0x0024a>
at Foundation.NSObject:Dispose <0x00074>
at Xamarin.Forms.Platform.iOS.ListViewRenderer:DisposeSubviews <0x00252>
at Xamarin.Forms.Platform.iOS.ListViewRenderer:DisposeSubviews <0x001a2>
at Xamarin.Forms.Platform.iOS.ListViewRenderer:DisposeSubviews <0x001a2>
at Xamarin.Forms.Platform.iOS.ListViewRenderer:DisposeSubviews <0x001a2>
at Xamarin.Forms.Platform.iOS.ListViewRenderer:Dispose <0x0021a>
at Foundation.NSObject:Dispose <0x00074>
at Xamarin.Forms.Platform.iOS.DisposeHelpers:DisposeModalAndChildRenderers <0x0030f>
at Xamarin.Forms.Platform.iOS.Platform:CleanUpPages <0x0019a>
at Xamarin.Forms.Platform.iOS.PlatformRenderer:Dispose <0x0018a>
at Foundation.NSObject:Dispose <0x00074>
at Xamarin.Forms.Platform.iOS.Platform:Dispose <0x000fa>
at Xamarin.Forms.Platform.iOS.Platform:Syst
em.IDisposable.Dispose <0x00071>
at Xamarin.Forms.Platform.iOS.FormsApplicationDelegate:UpdateMainPage <0x001eb>
at Xamarin.Forms.Platform.iOS.FormsApplicationDelegate:ApplicationOnPropertyChanged <0x000fa>
at Xamarin.Forms.BindableObject:OnPropertyChanged <0x00118>
at Xamarin.Forms.Element:OnPropertyChanged <0x000b2>
at Xamarin.Forms.Application:set_MainPage <0x00417>
at ChatUIXForms.Helpers.Methods:Logout <0x001ea>
at d__7:MoveNext <0x006e2>
at System.Runtime.CompilerServices.AsyncVoidMethodBuilder:Start <0x001be>
at ChatUIXForms.Views.MainPage:LogOut <0x0037a>
at Xamarin.Forms.MenuItem:OnClicked <0x000ab>
at Xamarin.Forms.MenuItem:Xamarin.Forms.IMenuItemController.Activate <0x00183>
at SecondaryToolbarItem:<.ctor>b__1_0 <0x00084>
at UIKit.UIControlEventProxy:Activated <0x000b1>
at System.Object:runtime_invoke_void__this__ <0x000e5>
at <0xffffffff>
at UIKit.UIApplication:UIApplicationMain <0x00259>
at UIKit.UIApplication:Main <0x000b2>

at UIKit.UIApplication:Main <0x00132>
at ChatUIXForms.iOS.Application:Main <0x00092>
at :runtime_invoke_void_object <0x00352>

Steps to Reproduce

Spam new page button in repro.
(In my project's case, just one page change is enough to get the exception)

Expected Behavior

New Page appears with video on it.

Actual Behavior

Video isn't disposed properly.

Basic Information

Version with issue: 4.5.0-pre4
Last known good version :N/A
IDE:Visual Studio 16.4.4
Platform Target Frameworks:
- iOS: 13.3
- Android: N/A
- UWP: N/A
Affected Devices: iPhone 8 simulator

Reproduction Link

VideoPlayer.zip

The text was updated successfully, but these errors were encountered:

cas8180 · 2020-04-03T22:45:39Z

This is a hypercritical bug for me. This pretty much makes it impossible to use this control/element within any iOS app. As soon as you navigate out of the page be pressing the back button the whole app crashes. Is there a work around for this? Or way to add this to a hotfix release? I think adding this to 4.6 is a really long timeline for something that is hypercritical like this.

jennablackwell · 2020-04-09T04:50:37Z

I'm experiencing the same crash with MediaElement. Navigating out of page with player causes a crash.

Saturn · 2020-04-09T13:24:16Z

I would also like to know if there is a quick and easy workaround for the time being.

Saturn · 2020-04-09T14:25:51Z

I used @StevenGranados's fix #9531 and still get exception.

Managed Stacktrace

	  at <unknown> <0xffffffff>
	  at ObjCRuntime.Messaging:void_objc_msgSend_IntPtr <0x00007>
	  at AVFoundation.AVPlayer:ReplaceCurrentItemWithPlayerItem <0x0005b>
	  at Xamarin.Forms.Platform.iOS.MediaElementRenderer:Dispose <0x002b7>
	  at Foundation.NSObject:Dispose <0x00023>

I then did

		protected override void Dispose(bool disposing)
		{
			base.Dispose(disposing);
                        return;
                        ///... rest of MediaElementRenderer disposal
                        ///...
                }

just to make sure it doesn't crash anymore which it doesn't.

My steps to reproduce were

Push new page with MediaElement. Click play on video.
Click back to pop page.
Page does pop but UI becomes unresponsive.

I notice these are slightly different than @StevenGranados.

StevenGranados · 2020-04-09T14:27:25Z

I'm currently using Octane.Xam.VideoPlayer. That's been working well for me for the time being.

code-hatchery · 2020-04-18T10:16:57Z

This change is fixing the crashes on back button for me. In the iOS MediaElementRenderer.cs change this:
AVPlayerViewController _avPlayerViewController = new AVPlayerViewController();

to this:
AVPlayerViewController _avPlayerViewController = new AVPlayerViewController() { Player = new AVPlayer() };

I did not apply the patch already linked to this bug.

code-hatchery · 2020-04-18T12:08:28Z

Ah, I see that the effect of that change I gave was to prevent the setup of the _rateObserver. So the real fix is in the dispose method by changing this:
_rateObserver.Dispose();

to this:
_avPlayerViewController?.Player?.RemoveObserver(_rateObserver, "rate");

Saturn · 2020-04-18T15:51:55Z

Cool @code-hatchery. I will try that fix.

Saturn · 2020-04-19T16:05:07Z

Ah, I see that the effect of that change I gave was to prevent the setup of the _rateObserver. So the real fix is in the dispose method by changing this:
_rateObserver.Dispose();

to this:
_avPlayerViewController?.Player?.RemoveObserver(_rateObserver, "rate");

Yes, this fix works nicely for me. 👍

brminnick · 2020-04-24T17:46:43Z

I confirmed that this bug happens when MediaElement is disposed.

When Dispose is called on Xamarin.Forms.Platform.iOS.MediaElementRenderer, a SIGSEVexception is thrown when _avPlayerViewController?.Player?.Pause(); is called.

Reproduction Steps

Download/clone this repository: https://github.com/brminnick/MediaElementRepro/
In Visual Studio, open MediaElementRepro.sln
Build/Deploy MediaElementRepro.iOS to an iOS Simulator or Device
In the iOS app, verify the video is playing
In the iOS app, tap the Open New Media Element Page Button
In the iOS app, verify the video is playing
In the iOS app, tap the Close button
In Visual Studio, confirm a SIGSEV exception is thrown
If no exception has been thrown, repeat Steps 6-8

Note: Despite the crash, the video may continue to play on the iOS device. We can confirm the app has crashed by getting no response when tapping the Open New Media Element Page Button

Stack Trace

 at <unknown> <0xffffffff>
	  at ObjCRuntime.Messaging:void_objc_msgSend <0x000e9>
	  at AVFoundation.AVPlayer:Pause <0x00122>
	  at Xamarin.Forms.Platform.iOS.MediaElementRenderer:Dispose <0x00253>
	  at Foundation.NSObject:Dispose <0x00074>
	  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x002c5>
	  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x00071>
	  at Xamarin.Forms.Platform.iOS.VisualElementRenderer`1:Dispose <0x0024a>
	  at Foundation.NSObject:Dispose <0x00074>
	  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x002c5>
	  at Xamarin.Forms.Platform.iOS.VisualElementPackager:Dispose <0x00071>
	  at Xamarin.Forms.Platform.iOS.PageRenderer:Dispose <0x0041a>
	  at Foundation.NSObject:Dispose <0x00074>
	  at Xamarin.Forms.Platform.iOS.DisposeHelpers:DisposeModalAndChildRenderers <0x0030f>
	  at <Xamarin-Forms-INavigation-PopModalAsync>d__25:MoveNext <0x008d2>
	  at MoveNextRunner:InvokeMoveNext <0x000ab>
	  at System.Threading.ExecutionContext:RunInternal <0x00585>
	  at System.Threading.ExecutionContext:Run <0x00092>
	  at MoveNextRunner:Run <0x001aa>
	  at System.Threading.Tasks.AwaitTaskContinuation:InvokeAction <0x00093>
	  at System.Threading.Tasks.AwaitTaskContinuation:RunCallback <0x00153>
	  at System.Threading.Tasks.SynchronizationContextAwaitTaskContinuation:Run <0x0013a>
	  at System.Threading.Tasks.Task:FinishContinuations <0x006a6>
	  at System.Threading.Tasks.Task:FinishStageThree <0x0015a>
	  at System.Threading.Tasks.Task`1:TrySetResult <0x0022a>
	  at System.Threading.Tasks.TaskCompletionSource`1:TrySetResult <0x00092>
	  at System.Threading.Tasks.TaskCompletionSource`1:SetResult <0x0007a>
	  at <>c__DisplayClass33_0:<DismissViewControllerAsync>b__0 <0x00082>
	  at SDAction:Invoke <0x00154>
	  at SDAction:Invoke <0x0010a>
	  at <unknown> <0xffffffff>
	  at UIKit.UIApplication:UIApplicationMain <0x00259>
	  at UIKit.UIApplication:Main <0x000b2>
	  at UIKit.UIApplication:Main <0x00132>
	  at MediaElementRepro.iOS.Application:Main <0x0007a>
	  at <Module>:runtime_invoke_void_object <0x00198>

https://github.com/brminnick/MediaElementRepro/

xamarin/Xamarin.Forms#9525 (comment)

Saturn · 2020-04-25T19:19:25Z

I have also observed the video continuing to play but UI becomes totally unresponsive,.

jefffhaynes · 2020-05-04T22:12:12Z

Any update on this? Bit of a blocking bug for us.

Az6bcn · 2020-05-09T17:51:31Z

Any updates on this bug? I'm having the same issue on ios when I click back to go to the previous page, the UI becomes unresponsive.

Saturn · 2020-05-09T21:24:02Z

@Az6bcn Have you tried

Changing
_rateObserver.Dispose();

to this:
_avPlayerViewController?.Player?.RemoveObserver(_rateObserver, "rate");

in the MediaElement renderer for iOS?

rodhemphill · 2020-05-18T07:14:47Z

I too am blocked with this @samhouts .

@Saturn, what do you mean "changing the MediaElement renderer"? Are you suggesting there is a way to get the repo for just the MediaElement and we add that to our project? I thought you could get the repo for all of Forms or none. Or am I missing what you mean with your comment to @Az6bcn?

I also note that @brminnick 's repo has been removed.

Saturn · 2020-05-18T07:23:44Z

Hi @rodhemphill ,

I copied the MediaElementRenderer from https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.iOS/Renderers/MediaElementRenderer.cs

Added it to my Xamarin iOS project, changed the class name to MediaElementRenderer2 and added

[assembly: ExportRenderer(typeof(MediaElement), typeof(MediaElementRenderer2))]

above namespace.

You possibly do not need to change name of class.

I then just changed the Dispose method slightly based on @code-hatchery suggestion

_rateObserver.Dispose();

to this:

_avPlayerViewController?.Player?.RemoveObserver(_rateObserver, "rate");

This allowed me to use the MediaElement on iOS without the crashing issue. I really would hope the fix goes in sooner rather than later because this is just a quick workaround that worked for me.

brminnick · 2020-05-18T14:57:24Z

@rodhemphill Thanks for the heads up! The repro link should work now: https://github.com/brminnick/MediaElementRepro

npagare · 2020-07-28T01:38:30Z

Hi All,

In iOS version of my app, when I navigate back from a page that has MediaManager, I get an error in the output which is indicating that the dispose is not called. As a result my app becomes totally non responsive.

Do we have to call Dispose method on MediaManager explicitly in iOS Platform project or in Shared project ? [ this is not an issue with Android ]

iOS[57831:4538755] Warning: observer object was not disposed manually with Dispose()

=================================================================

Basic Fault Address Reporting

Memory around native instruction pointer (0x7fff512525f1):0x7fff512525e1 08 5b 41 5e 41 5f 5d c3 48 85 ff 7e 09 48 8b 07 .[A^A_].H..~.H..
0x7fff512525f1 8a 40 1c 24 01 c3 31 c0 c3 48 85 ff 74 17 78 1d .@.$..1..H.
.t.x.
0x7fff51252601 48 8b 07 48 85 c0 74 0d 48 89 c7 be 01 00 00 00 H..H..t.H.......
0x7fff51252611 e9 a0 d4 00 00 48 8d 05 5b 1c 02 00 c3 48 89 f8 .....H..[....H..

=================================================================

Managed Stacktrace:

at <0xffffffff>
at ObjCRuntime.Messaging:void_objc_msgSend <0x000e1>
at AVFoundation.AVPlayer:Pause <0x00122>
at Xamarin.Forms.Platform.iOS.MediaElementRenderer:Dispose <0x00327>

npagare · 2020-07-29T03:30:51Z

Hi @samhouts - is the fix for this issue going to be packaged with XF 4.8 Pre 3 ?

thisisthekap · 2020-10-07T09:05:16Z

@samhouts Please reopen this bug because the fix for it was reverted in #11862

dalinet · 2020-10-27T19:18:46Z

Hi @rodhemphill ,

I copied the MediaElementRenderer from https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.iOS/Renderers/MediaElementRenderer.cs

Added it to my Xamarin iOS project, changed the class name to MediaElementRenderer2 and added
[assembly: ExportRenderer(typeof(MediaElement), typeof(MediaElementRenderer2))]
above namespace.

You possibly do not need to change name of class.

I then just changed the Dispose method slightly based on @code-hatchery suggestion
_rateObserver.Dispose();
to this:
_avPlayerViewController?.Player?.RemoveObserver(_rateObserver, "rate");
This allowed me to use the MediaElement on iOS without the crashing issue. I really would hope the fix goes in sooner rather than later because this is just a quick workaround that worked for me.

Incredible solution, Thanks Friend!!!!!

StevenGranados added s/unverified New report that has yet to be verified t/bug 🐛 labels Feb 11, 2020

StevenGranados changed the title ~~[Bug] MediaElement Disposing exception when MainPage is changed.~~ [Bug] MediaElement Disposing exception when MainPage is changed on iOS Feb 11, 2020

StevenGranados mentioned this issue Feb 11, 2020

[REVERTED] [MediaElement] Removed line that pauses player before setting it to null. #9531

Merged

2 tasks

samhouts added a/mediaelement i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/iOS 🍎 in-progress This issue has an associated pull request that may resolve it! labels Feb 12, 2020

samhouts added e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Feb 13, 2020

samhouts mentioned this issue Feb 13, 2020

[Bug][iOS] MediaElement SIGSEGV #9569

Closed

brminnick added a commit to brminnick/GitTrends that referenced this issue Apr 24, 2020

Removed MediaElement on iOS

13532ab

xamarin/Xamarin.Forms#9525 (comment)

samhouts closed this as completed in 9f3410b Aug 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] MediaElement Disposing exception when MainPage is changed on iOS #9525

[Bug] MediaElement Disposing exception when MainPage is changed on iOS #9525

StevenGranados commented Feb 11, 2020

cas8180 commented Apr 3, 2020

jennablackwell commented Apr 9, 2020

Saturn commented Apr 9, 2020

Saturn commented Apr 9, 2020 •

edited

Loading

StevenGranados commented Apr 9, 2020

code-hatchery commented Apr 18, 2020

code-hatchery commented Apr 18, 2020

Saturn commented Apr 18, 2020

Saturn commented Apr 19, 2020

brminnick commented Apr 24, 2020 •

edited

Loading

Saturn commented Apr 25, 2020

jefffhaynes commented May 4, 2020

Az6bcn commented May 9, 2020

Saturn commented May 9, 2020

rodhemphill commented May 18, 2020

Saturn commented May 18, 2020

brminnick commented May 18, 2020

npagare commented Jul 28, 2020

npagare commented Jul 29, 2020

thisisthekap commented Oct 7, 2020

dalinet commented Oct 27, 2020

[Bug] MediaElement Disposing exception when MainPage is changed on iOS #9525

[Bug] MediaElement Disposing exception when MainPage is changed on iOS #9525

Comments

StevenGranados commented Feb 11, 2020

Description

================================================================= Native Crash Reporting

Got a SIGSEGV while executing native code. This usually indicates a fatal error in the mono runtime or one of the native libraries used by your application.

================================================================= Native stacktrace:

================================================================= Basic Fault Address Reporting

================================================================= Managed Stacktrace:

at UIKit.UIApplication:Main <0x00132> at ChatUIXForms.iOS.Application:Main <0x00092> at :runtime_invoke_void_object <0x00352>

Steps to Reproduce

Expected Behavior

Actual Behavior

Basic Information

Reproduction Link

cas8180 commented Apr 3, 2020

jennablackwell commented Apr 9, 2020

Saturn commented Apr 9, 2020

Saturn commented Apr 9, 2020 • edited Loading

StevenGranados commented Apr 9, 2020

code-hatchery commented Apr 18, 2020

code-hatchery commented Apr 18, 2020

Saturn commented Apr 18, 2020

Saturn commented Apr 19, 2020

brminnick commented Apr 24, 2020 • edited Loading

Reproduction Steps

Stack Trace

Saturn commented Apr 25, 2020

jefffhaynes commented May 4, 2020

Az6bcn commented May 9, 2020

Saturn commented May 9, 2020

rodhemphill commented May 18, 2020

Saturn commented May 18, 2020

brminnick commented May 18, 2020

npagare commented Jul 28, 2020

Basic Fault Address Reporting

Managed Stacktrace:

npagare commented Jul 29, 2020

thisisthekap commented Oct 7, 2020

dalinet commented Oct 27, 2020

=================================================================
Native Crash Reporting

Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.

=================================================================
Native stacktrace:

=================================================================
Basic Fault Address Reporting

=================================================================
Managed Stacktrace:

at UIKit.UIApplication:Main <0x00132>
at ChatUIXForms.iOS.Application:Main <0x00092>
at :runtime_invoke_void_object <0x00352>

Saturn commented Apr 9, 2020 •

edited

Loading

brminnick commented Apr 24, 2020 •

edited

Loading