Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Obsolete message for Device.OpenUri mentions non-existent APIs #11433

Closed
Eilon opened this issue Jul 14, 2020 · 1 comment
Closed

Obsolete message for Device.OpenUri mentions non-existent APIs #11433

Eilon opened this issue Jul 14, 2020 · 1 comment
Assignees
@jsuarezruiz
Labels
Core e/1 🕐 1 in-progress This issue has an associated pull request that may resolve it! t/bug 🐛

Comments

@Eilon
Copy link
Contributor

Eilon commented Jul 14, 2020

Device.OpenUri is marked as obsolete with this message:

Xamarin.Forms/Xamarin.Forms.Core/Device.cs

Line 227 in 991f109

[Obsolete("OpenUri is obsolete as of version 4.3.0. Use Launcher.OpenUri (or CanOpen, or TryOpen) from Xamarin.Essentials")]

But none of those APIs exist on Launcher. These are the APIs that exist:

  • OpenAsync
  • TryOpenAsync
  • CanOpenAsync

The message should be updated to reflect the correct API names.
@Eilon
Copy link
Contributor Author

Eilon commented Jul 14, 2020

This is where the obsolete message was originally added: #6844

Eilon added a commit that referenced this issue Jul 14, 2020
@Eilon
Fix OpenUri obsoletion message
23ed9d0 
Fixes #11433
@Eilon Eilon mentioned this issue Jul 14, 2020
Closed
2 tasks
@jsuarezruiz jsuarezruiz self-assigned this Jul 15, 2020
Eilon added a commit that referenced this issue Jul 15, 2020
@Eilon
Fix OpenUri obsoletion message
92ca1ff 
Fixes #11433
@Eilon Eilon mentioned this issue Jul 15, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
Core e/1 🕐 1 in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OpenUri obsoletion message xamarin/Xamarin.Forms
3 participants
@Eilon @jsuarezruiz @samhouts