Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DIM for AndroidX packages. #718

Merged
merged 4 commits into from
May 9, 2023
Merged

Enable DIM for AndroidX packages. #718

merged 4 commits into from
May 9, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Apr 6, 2023

Context: #715
Context: #611

Some AndroidX interfaces provide useful API as default interface methods. Support for default interface methods has been added to C# and our Android binding tools.

Enable $(AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods) so that this support is turned on.

Per the API diffs, this does not cause any existing API to be modified, it only adds new API.

A few problematic default interface methods were removed via metadata because they caused compile errors.

@jpobst jpobst marked this pull request as ready for review May 5, 2023 15:03
@jpobst jpobst changed the title Enable DIM and SIM for AndroidX packages. Enable DIM for AndroidX packages. May 5, 2023
@jpobst jpobst requested a review from moljac May 5, 2023 15:16
@jpobst jpobst merged commit 4975fce into main May 9, 2023
@jpobst jpobst deleted the allow-dim branch May 9, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants