feat: support underscore in tag #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个改动非常小，vscode 的 syntax highlight 语法我也是今晚现学的。检查清单里面的事情对于这个改动来说比较重，能否请维护者帮忙完成？ |
|
@alsotang 好的，晚上下班我回家做好测试，OK的话发新版本，明天可以用上 |
|
加啦，麻烦通过下！ |
alsotang
force-pushed
the
support_underscore_in_tag
branch
from
b537a6c
to
c0d605b
Compare
iChenLei
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决了什么问题: 在tag name当中支持高亮下划线
如图所示，这个
map_card没有正确高亮。但实际上程序可以正常运行，并且根据 https://developers.weixin.qq.com/miniprogram/dev/framework/custom-component/ ，下划线是合法的。代码如何实现: 改了tag语法的正则表达式
检查清单: