Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http (fix): Handle RPCException thrown in local web apps #3140

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 12, 2023

No description provided.

@github-actions github-actions bot added the bug label Aug 12, 2023
@xerial xerial enabled auto-merge (squash) August 12, 2023 19:55
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #3140 (46463a6) into main (5dc3ec1) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
+ Coverage   82.88%   82.90%   +0.01%     
==========================================
  Files         350      350              
  Lines       14737    14739       +2     
  Branches     2440     2448       +8     
==========================================
+ Hits        12215    12219       +4     
+ Misses       2522     2520       -2     
Files Changed Coverage Δ
...scala/wvlet/airframe/http/client/HttpClients.scala 90.72% <100.00%> (+0.18%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc3ec1...46463a6. Read the comment docs.

@xerial xerial merged commit 016f929 into main Aug 12, 2023
17 checks passed
@xerial xerial deleted the rpc-error-handler branch August 12, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant