Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rx-html (fix): Properly call onMount hook when internal Rx is updated #3119

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 8, 2023

@github-actions github-actions bot added bug internal Internal changes (usually non-user facing) labels Aug 8, 2023
@xerial xerial enabled auto-merge (squash) August 8, 2023 07:56
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #3119 (c919a28) into main (2d9f38b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3119   +/-   ##
=======================================
  Coverage   82.84%   82.85%           
=======================================
  Files         350      350           
  Lines       14723    14723           
  Branches     2447     2447           
=======================================
+ Hits        12198    12199    +1     
+ Misses       2525     2524    -1     
Files Changed Coverage Δ
.../main/scala/wvlet/airframe/rx/html/RxElement.scala 82.35% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9f38b...c919a28. Read the comment docs.

@xerial xerial merged commit ca25718 into main Aug 8, 2023
17 checks passed
@xerial xerial deleted the rx-on-render branch August 8, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rx-html: Failed to call onMount in nested RxElements
1 participant