This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Fix bugs detected by Sonarcloud after merging branch 250 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvvcJ00hBq3sdkpU&open=AWT1cvvcJ00hBq3sdkpU - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cv4YJ00hBq3sdkpw&open=AWT1cv4YJ00hBq3sdkpw - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvwrJ00hBq3sdkpW&open=AWT1cvwrJ00hBq3sdkpW - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvTNJ00hBq3sdknX&open=AWT1cvTNJ00hBq3sdknX
added 2 commits
August 2, 2018 12:00
Fix: - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvlJJ00hBq3sdkoD&open=AWT1cvlJJ00hBq3sdkoD - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvlJJ00hBq3sdkoE&open=AWT1cvlJJ00hBq3sdkoE - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvcHJ00hBq3sdknz&open=AWT1cvcHJ00hBq3sdknz - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvZHJ00hBq3sdknr&open=AWT1cvZHJ00hBq3sdknr - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvR7J00hBq3sdknV&open=AWT1cvR7J00hBq3sdknV - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvcHJ00hBq3sdkn0&open=AWT1cvcHJ00hBq3sdkn0
Fix: - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvdMJ00hBq3sdkn5&open=AWT1cvdMJ00hBq3sdkn5 - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvcnJ00hBq3sdkn2&open=AWT1cvcnJ00hBq3sdkn2 - https://sonarcloud.io/project/issues?id=com.cognifide.qa.bb&issues=AWT1cvcnJ00hBq3sdkn1&open=AWT1cvcnJ00hBq3sdkn1
mkrzyzanowski
approved these changes
Aug 2, 2018
| try { | ||
| return pageCount == getChildPageWindow().getPageCount(); | ||
| } catch (StaleElementReferenceException e) { | ||
| Objects.requireNonNull(webDriver).navigate().refresh(); |
There was a problem hiding this comment.
This is redundant, Guice can't inject nulls.
| PageActivationStatus pageActivationStatusCell = childPageRow.getPageActivationStatus(); | ||
| ActivationStatus activationStatus = pageActivationStatusCell.getActivationStatus(); | ||
| return activationStatus == status; | ||
| Objects.requireNonNull(webDriver).navigate().refresh(); |
Shaihuludus
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
Description
Motivation and Context
Types of changes
Checklist: