Implement h2 aggregation #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldclakmal
force-pushed
the
update-http2-performance-test
branch
from
4899790
to
664a0e1
Compare
ldclakmal
force-pushed
the
update-http2-performance-test
branch
from
26ec7eb
to
08f91ba
Compare
…nto update-http2-performance-test # Conflicts: # components/netty-http-echo-service/src/main/java/org/wso2/performance/common/netty/echo/EchoHttpServer.java
arukshani
reviewed
Mar 6, 2019
...echo-service/src/main/java/org/wso2/performance/common/netty/echo/EchoHttpServerHandler.java
Outdated
Show resolved
Hide resolved
ldclakmal
force-pushed
the
update-http2-performance-test
branch
from
2aae3d0
to
002a114
Compare
…clakmal/performance-common into update-http2-performance-test # Conflicts: # components/netty-http-echo-service/src/main/java/org/wso2/performance/common/netty/echo/EchoHttp2ServerHandler.java # components/netty-http-echo-service/src/main/java/org/wso2/performance/common/netty/echo/EchoHttpServerHandler.java
arukshani
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR will introduce h2 message aggregation which gets the full HTTP request before the responding. But according to the HTTP/2 specification [1] server can respond before receiving the complete request.
NOTE: Currently, h2 message aggregation does not support for h2c.
Please refer [2] for more info on h2 message aggregation with netty.
[1] https://tools.ietf.org/html/rfc7540#page-51
[2] netty/netty#7908
Fixes ballerina-platform/ballerina-lang#13953