Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated with changes for v5.44.0.
I'm not very experienced with typescript and typings, so I essentially copied how the other typings looked.
npm run test
andnpm run lint
run without errors.I had a few issues, where I'm curios how you'd have done that:
setCameraBoundaryAnimated
accepts two different types as its first parameter, but according to Apple's docs they use a different parameter name depending on the type (coordinateRegion: mapkit.CoordinateRegion | mapRect: mapkit.MapRect
), which (as far as I understand – please correct me if I'm wrong) is not supported in typescript. I tried overloading the method, i.e. adding it twice (one for each parameter name), but the linter insisted on combining them, and I wasn't sure if silencing the linter is more desirable, so I changed it.See the docs here and the line in my code here.
I'm happy about feedback, or also happy to change anything, just let me know!