Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: sysdrive_prefix returning wrong label when Windows installed at label other than C: #262

Merged

Conversation

epiciskandar
Copy link
Contributor

Description

My PC have Windows installed at w:/ which would be mounted in wsl at /mnt/w. I found that wslu got wrong path /mnt/c. A bugfix is needed.

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected) are no longer accepted

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read Code of Conduct and Contributing documentations.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

notice: I've ran all bats tests, but some tests assumed Windows is locating at /mnt/c, so they got fail in my environment, this is not a real problem IMO.

src/wslu-header Outdated Show resolved Hide resolved
Copy link
Member

@patrick330602 patrick330602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick330602 patrick330602 merged commit 297f6ef into wslutilities:dev/master Jan 24, 2023
@epiciskandar epiciskandar deleted the dev/sysdrive_prefix_fix branch January 25, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants