Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in user path still broken #144

Closed
plttn opened this issue Aug 26, 2020 · 1 comment · Fixed by #145
Closed

Spaces in user path still broken #144

plttn opened this issue Aug 26, 2020 · 1 comment · Fixed by #145
Labels
Bug This is either an issue that describes a bug or a PR that resolves a bug Status: Pending Release This is fixed but not yet released. Target: LTS This is targeted to the LTS release. Target: 3.x This is targeted to the 3.x version.

Comments

@plttn
Copy link

plttn commented Aug 26, 2020

Background Information:

  • Build: 19041
  • WSL: Pengwin

Describe the bug
Spaces in user path still cause issues with wslfetch and wslsys

To Reproduce

  • have space in user path (C:\Users\Jack Platten....)
  • run wslfetch or wslsys
  • observe "the term 'C:\Users\Jack' is not recognized as the name of a cmdlet...

Expected behavior

@patrick330602 patrick330602 added Bug This is either an issue that describes a bug or a PR that resolves a bug Target: LTS This is targeted to the LTS release. Target: 3.x This is targeted to the 3.x version. labels Sep 4, 2020
@loadhigh
Copy link

loadhigh commented Sep 5, 2020

In wslsys:

function call_display_scaling() {
    up_path="$(wslvar -s USERPROFILE)"
    wslu_file_check "$(wslpath "$up_path")/wslu" "get_dpi.ps1" "?!S"
    display_scaling="$(winps_exec "$(double_dash_p "$up_path" | sed -e 's| |\` |g')\\wslu\\get_dpi.ps1" | sed -e 's|\r||g')"
    bc -l <<< "$(printf "%d\n" "$display_scaling")/100" | sed -e "s/\.0//g" -e "s/0*$//g"
}

Fixed by adding sed -e 's| |\` |g'

EDIT: forgot g

loadhigh added a commit to loadhigh/loadhigh-overlay that referenced this issue Sep 6, 2020
Patch for wslutilities/wslu#144

Package-Manager: Portage-3.0.4, Repoman-2.3.23
@patrick330602 patrick330602 added the Status: In Progress This is being worked on and not ready. label Sep 7, 2020
patrick330602 added a commit that referenced this issue Sep 7, 2020
@patrick330602 patrick330602 added Status: Pending Release This is fixed but not yet released. and removed Status: In Progress This is being worked on and not ready. labels Sep 9, 2020
loadhigh added a commit to loadhigh/loadhigh-overlay that referenced this issue Apr 3, 2024
Patch for wslutilities/wslu#144

Package-Manager: Portage-3.0.4, Repoman-2.3.23
loadhigh added a commit to loadhigh/loadhigh-overlay that referenced this issue Apr 11, 2024
Patch for wslutilities/wslu#144

Package-Manager: Portage-3.0.4, Repoman-2.3.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either an issue that describes a bug or a PR that resolves a bug Status: Pending Release This is fixed but not yet released. Target: LTS This is targeted to the LTS release. Target: 3.x This is targeted to the 3.x version.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants