Switch to tomllib #4
Conversation
This allows for clean, in place edits of Cargo.toml that retain all formatting and comments. Closes wraithan#1
|
Wow this is fantastic! I just noticed this and I'm about to go to sleep. I'll give this a test tomorrow and merge it in. Been meaning to get back to this project but just hasn't been top priority. Thank you so much for sending this. I learned a couple techniques I didn't know about that will make the code cleaner for sure. |
|
Just pushed a small refactoring. Let me know if there's anything else I can do to help get this merged. Thanks! |
|
ping |
|
@wraithan Still interested in getting this merged! Let me know if there's anything I can do to help 😄 |
|
@lukesteensen I'm merging this now. I didn't back then because it'd been months since I'd thought about the project when you sent the PR, and I've not needed it at all since that point. I'd saw that you rewrote about half the project and that meant vetting it more. |
|
@wraithan Yes, unfortunately, the new library's API was significantly different from the old library and that made the required changes more invasive than I would have liked. I appreciate you taking the time to look at it and get it merged. |
|
Nah, I totally get it now that I've actually read the changes and saw how different the API was (and how bad my code is/was) |
|
This has been published as cargo-bump 1.0.0 on crates.io |
|
Thank you! |
|
Deleted some discussion that didn't really pertain to the PR to clean things up. |
This allows for clean, in place edits of Cargo.toml that retain all formatting and comments.
Closes #1