Links UI using BottomSheet component #623
Conversation
|
I have a question regarding the divider lines: I understand they're not going to the edges because they're within a container, which makes sense. Is that on all sheets, or just this links one? I believe I've seen the dividers on the Image Settings sheet go to the right edge but maybe I'm dreaming 😄 I just want to make sure we're being consistent and that I'm generally aware of the differences. |
It's on all of them. Some time ago they were going until the edge, but that was because they were overflowing, drown outside the container. We didn't noticed it until we did the max-width 😁 It shouldn't be difficult to adjust the containers to allow de dividers to go until the edge. |
Ok fair enough. Not a big concern as we'll sort it out soon. 😄 Because I've written so much css in a past life, my brain goes to utilizing the |
Just tested, and it doesn't work 😞 |
|
Curse you, RN! shakes fist – I would've been delightfully surprised had it worked 😆 |
|
Until we have a solution for extending the dividers beyond the containers, what do you think about extending the dividers to the icons as well, so that the dividers are 16pt from each edge of the sheet. It would look like this:
Until we are able to sort the dividers-to-the-right-edge thing, this might feel pretty balanced. In fact I don't even mind if we stick with this for a while 😄 |
There was a problem hiding this comment.
@etoledom - I'm not sure how the gutenberg side PR got approved without this one being approved, but this should be good to go.
|
Thank you @diegoreymendez ! |
This PR updates the Gutenberg ref. to test WordPress/gutenberg#13972
To test: