[Mobile] - Refactor BlockListItem #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
This PR is closed because there is no longer an associated If you'd like to keep a PR open after its upstream counterpart is closed, please assign it to a team member or create a new commit. |
wpmobilebot
deleted the
version-toolkit/gutenberg/rnmobile/refactor-block-list-item
branch
geriux
restored the
version-toolkit/gutenberg/rnmobile/refactor-block-list-item
branch
geriux
force-pushed
the
version-toolkit/gutenberg/rnmobile/refactor-block-list-item
branch
from
bef95ee
to
8f2e87f
Compare
geriux
force-pushed
the
version-toolkit/gutenberg/rnmobile/refactor-block-list-item
branch
3 times, most recently
from
83a0275
to
d8013a8
Compare
geriux
force-pushed
the
version-toolkit/gutenberg/rnmobile/refactor-block-list-item
branch
from
d8013a8
to
e1a9f38
Compare
dcalhoun
approved these changes
May 4, 2023
There was a problem hiding this comment.
Approved via WordPress/gutenberg#49765 (review). Looks like we have a single visual test failing, we may need an updated snapshot.
There was a problem hiding this comment.
This snapshot was updated slightly. It appears the sibling visual test for Android is failing. Maybe it needs an updated snapshot as well?
… value instead of the offset.
geriux
reviewed
May 4, 2023
…-block-list-item # Conflicts: # gutenberg
geriux
deleted the
version-toolkit/gutenberg/rnmobile/refactor-block-list-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.