Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gutenberg subrepo from master #347

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Update gutenberg subrepo from master #347

merged 2 commits into from
Dec 11, 2018

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Dec 11, 2018 •
edited
Loading

Changes reside in the child PR.

To Test

Try on both iOS and android

  • Boot the app
  • Try switching from visual to html and back
  • Try moving blocks up and down
  • Try adding a new block of every type
  • Try splitting an existing block
  • Try adding a new block while an empty/replaceable block is selected
  • Try removing blocks
  • Try editing in blocks
  • Try undo/redo changes

@pinarol pinarol added this to the Alpha milestone Dec 11, 2018
@pinarol pinarol self-assigned this Dec 11, 2018
@pinarol pinarol mentioned this pull request Dec 11, 2018
Merged
4 tasks
@hypest hypest self-requested a review December 11, 2018 12:53
hypest
hypest approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to update the GB ref to latest mobile(after GB side PR gets merged) and merge this one too 👍

@pinarol pinarol merged commit f1f21ba into master Dec 11, 2018
@pinarol pinarol deleted the update/gutenberg-from-master branch December 11, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@pinarol pinarol

Labels
None yet
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @hypest