Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode Design review #1811

Closed
wants to merge 3 commits into from
Closed

Shortcode Design review #1811

wants to merge 3 commits into from

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jan 23, 2020 •
edited
Loading

Fixes #1810
Gutenberg PR: WordPress/gutenberg#19852

To test:
Add Shortcode block and compare design in light and dark mode. See WordPress/gutenberg#19852 for screenshots

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added the [Status] Needs Design Review Needs design review or sign-off before shipping label Jan 23, 2020
@chipsnyder chipsnyder added this to the 1.22 milestone Jan 23, 2020
@chipsnyder chipsnyder requested a review from koke January 23, 2020 21:52
@chipsnyder chipsnyder changed the title Update Gutenberg reference Shortcode Design review Jan 24, 2020
@chipsnyder chipsnyder marked this pull request as ready for review January 24, 2020 16:26
@chipsnyder chipsnyder removed the [Status] Needs Design Review Needs design review or sign-off before shipping label Jan 24, 2020
@chipsnyder
Copy link
Contributor Author

Closing a later commit is already merged

@chipsnyder chipsnyder closed this Jan 28, 2020
@chipsnyder chipsnyder deleted the issue/1810-shortcode-design branch January 28, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke Awaiting requested review from koke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

Update Shortcode design elements from design review
1 participant
@chipsnyder