Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Autocomplete in shortcode #1809

Closed
wants to merge 2 commits into from
Closed

Disable Autocomplete in shortcode #1809

wants to merge 2 commits into from

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jan 23, 2020 •
edited
Loading

Fixes: #1808
Gutenberg PR: WordPress/gutenberg#19848

To test:
Tested in Gutenberg-mobile demo app

  1. Open the app
  2. Add a shortcode block
  3. Start editing
  4. Expect that the autocomplete suggestions are not displayed
iOS Android
iOS Android

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added this to the 1.22 milestone Jan 23, 2020
@chipsnyder chipsnyder requested review from koke and maxme January 23, 2020 17:06
@chipsnyder chipsnyder mentioned this pull request Jan 23, 2020
Merged
6 tasks
@chipsnyder chipsnyder marked this pull request as ready for review January 24, 2020 14:42
@chipsnyder
Copy link
Contributor Author

Closing a later PR updated Gutenberg beyond this commit

@chipsnyder chipsnyder closed this Jan 28, 2020
@chipsnyder chipsnyder deleted the issue/1808-shortcode-autocomplete branch January 28, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke Awaiting requested review from koke

@maxme maxme Awaiting requested review from maxme

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

Disable Autocomplete in Shortcode block
1 participant
@chipsnyder