Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add media edit icon to image block #1782
Add media edit icon to image block #1782
Changes from 13 commits
24c44bd
5cc7b7c
723422e
fec309e
a19bc00
4afaf29
deef065
6011985
7702822
da9adaa
7dd6e18
e91b9f3
4928edf
5ca3c27
4535a1b
1e3bd5f
29fcef5
6228bb5
cce42b1
2257b1c
dd2e639
063ec30
d268e4e
bed0461
7dd42a9
999f0df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a PR to WPAndroid that adds this new parameter where
GutenbergContainerFragment
calls this method. Otherwise, merging this will break building Gutenberg from source on WPAndroid (i.e., building withwp.BUILD_GUTENBERG_FROM_SOURCE=true
added to WPAndroid'sgradle.properties
file).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in wordpress-mobile/WordPress-Android#11175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Maybe we could use
media
directly