Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS dark mode improvements #1415

Merged
merged 5 commits into from
Oct 9, 2019
Merged

iOS dark mode improvements #1415

merged 5 commits into from
Oct 9, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 7, 2019 •
edited
Loading

Fixes #1391 by the changes on WordPress/gutenberg#17802

This PR also fixes another DarkMode issue I found while testing this:

  • Typing attributes won't update appropriately when textColor changes.

dark-mode-issue

To test:

  • Checkout gutenberg-mobile PR: TBD
  • Run the project on iOS 13 with dark mode.
  • Add a List block.
  • Check that the placeholder is properly lied out.
    --
  • Switch to light mode.
  • Create a new List block.
  • Write some text on it.
  • Switch to dark mode.
  • Delete the text and write new text.
  • Check that the text color is white.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added [Type] Enhancement Improves a current area of the editor Dark mode labels Oct 7, 2019
@etoledom etoledom added this to the 1.15 milestone Oct 7, 2019
@etoledom etoledom self-assigned this Oct 7, 2019
@etoledom etoledom mentioned this pull request Oct 7, 2019
Merged
SergioEstevao
SergioEstevao approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this fix!

@etoledom etoledom merged commit a2623b9 into develop Oct 9, 2019
@etoledom etoledom deleted the issue/1391-ios-dark-mode-issues branch October 9, 2019 06:25
@phillipcornwell
Copy link

Testing Environment:
iOS 13.1.3
iPhone 7 Plus

Results:
This works well for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@etoledom etoledom

Labels
Dark mode [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

[iOS] List block: Bullet overlaps placeholder in dark mode
3 participants
@etoledom @phillipcornwell @SergioEstevao