Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BottomSheet icon color fix #1326

Merged
merged 2 commits into from
Aug 26, 2019
Merged

BottomSheet icon color fix #1326

merged 2 commits into from
Aug 26, 2019

Conversation

etoledom
Copy link
Contributor

This PR fixes an issue where on Android, the BottomSheet icons where white (or transparent)

This is by setting both regular and dark color right into the color prop of DashIcon, instead of using DashIcon class.

gutenberg PR: WordPress/gutenberg#17193

To test:

  • Run on Android
  • Show the BottomSheet
  • Check that the icons are visible and gray

@etoledom etoledom added this to the 1.11 milestone Aug 26, 2019
@etoledom etoledom requested a review from Tug August 26, 2019 13:10
@etoledom etoledom self-assigned this Aug 26, 2019
@etoledom etoledom changed the base branch from develop to release/1.11.0 August 26, 2019 13:10
@etoledom etoledom mentioned this pull request Aug 26, 2019
Merged
@etoledom etoledom merged commit 0fb2545 into release/1.11.0 Aug 26, 2019
@etoledom etoledom deleted the issue/fix-bottom-sheet-icon-colors branch August 26, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

Assignees

@etoledom etoledom

Labels
bugfix
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @Tug