Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial html after changes to text alignment #1306

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix initial html after changes to text alignment #1306

merged 1 commit into from
Aug 21, 2019

Conversation

koke
Copy link
Member

@koke koke commented Aug 21, 2019

WordPress/gutenberg#16794 changed the way alignment is serialized from an inline style to a class name, which caused validation errors on the demo content.

To test:

  • Launch the demo app and verify there are no validation errors.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@koke koke added the Tooling label Aug 21, 2019
@koke koke added this to the 1.12 milestone Aug 21, 2019
@koke koke requested a review from mkevins August 21, 2019 09:10
etoledom
etoledom approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect! Thank you 🙏

@koke koke merged commit df59399 into develop Aug 21, 2019
@koke koke deleted the fix/initial-html branch August 21, 2019 10:08
@hypest hypest mentioned this pull request Oct 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@mkevins mkevins Awaiting requested review from mkevins

Assignees
No one assigned
Labels
Tooling
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
2 participants
@koke @etoledom