Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the MediaText block #1258

Merged
merged 17 commits into from
Aug 29, 2019
Merged

Add support for the MediaText block #1258

merged 17 commits into from
Aug 29, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Aug 6, 2019

Implements #689

Gutenberg PR: WordPress/gutenberg#16305

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol pinarol self-requested a review August 22, 2019 13:26
@@ -4,206 +4,33 @@
*/

export default `
<!-- wp:image -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these will be added back before merging right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Let's not forget to revert those changes 👍

@etoledom etoledom self-assigned this Aug 29, 2019
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etoledom
Copy link
Contributor

Merging this since the failing UI tests are not related to this PR.

@etoledom etoledom merged commit 1ef05e2 into develop Aug 29, 2019
@etoledom etoledom deleted the add/media-text branch August 29, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants