Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Low pri] Fix build for node v12.4.0 #1181

Merged
merged 8 commits into from
Jul 10, 2019
Merged

[Low pri] Fix build for node v12.4.0 #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab569ca
Upgrade node-sass
Tug Jun 26, 2019
bb97dac
Run yarn upgrade to metro-core/fsevents build error
Tug Jun 26, 2019
e84a7e1
Update README.md to use the latest npm version
Tug Jul 9, 2019
893108e
Rename jsdom-jscore dependency to jsdom-jscore-rn
Tug Jul 9, 2019
c0c5ea5
Merge remote-tracking branch 'origin/develop' into fix/support-node-1…
Tug Jul 9, 2019
225ec1a
Update gutenberg ref to master
Tug Jul 9, 2019
ad46d41
Track develop gutenberg ref
Tug Jul 10, 2019
0a8bdd7
Merge remote-tracking branch 'origin/develop' into fix/support-node-1…
Tug Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $ git submodule update
Before running the demo app, you need to download and install the project dependencies. This is done via the following command:

```
nvm install v8.12.0
nvm install --latest-npm
yarn install
```

Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@
},
"dependencies": {
"@babel/runtime": "^7.3.1",
"@react-native-community/cli": "^1.5.2",
"classnames": "^2.2.5",
"dom-react": "^2.2.1",
"domutils": "^1.7.0",
Expand All @@ -130,14 +131,14 @@
"jest-serializer-enzyme": "^1.0.0",
"js-beautify": "^1.7.5",
"jsc-android": "236355.x.x",
"jsdom-jscore": "git+https://github.com/iamcco/jsdom-jscore-rn.git#a562f3d57c27c13e5bfc8cf82d496e69a3ba2800",
"jsdom-jscore-rn": "git+https://github.com/iamcco/jsdom-jscore-rn.git#a562f3d57c27c13e5bfc8cf82d496e69a3ba2800",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, do we have to have 2 lines/deps here even though they point to the very same commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added automatically by yarn upgrade, probably because the package it's pointing at was renamed jsdom-jscore-rn.
I think we should keep jsdom-jscore-rn only and update the imports here https://github.com/wordpress-mobile/gutenberg-mobile/blob/develop/src/globals.js#L7
Updating 👍

"jsx-to-string": "^1.3.1",
"memize": "^1.0.5",
"metro-react-native-babel-transformer": "^0.53.0",
"moment": "^2.22.1",
"moment-timezone": "^0.5.16",
"node-libs-react-native": "^1.0.2",
"node-sass": "^4.8.3",
"node-sass": "^4.12.0",
"react": "16.8.3",
"react-native": "0.59.3",
"react-native-hr": "git+https://github.com/Riglerr/react-native-hr.git#2d01a5cf77212d100e8b99e0310cce5234f977b3",
Expand Down
4 changes: 2 additions & 2 deletions src/globals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
/**
* External dependencies
*/
import jsdom from 'jsdom-jscore';
import jsdomLevel1Core from 'jsdom-jscore/lib/jsdom/level1/core';
import jsdom from 'jsdom-jscore-rn';
import jsdomLevel1Core from 'jsdom-jscore-rn/lib/jsdom/level1/core';
import { nativeLoggingHook } from 'react-native-gutenberg-bridge';

/**
Expand Down
4 changes: 2 additions & 2 deletions src/jsdom-patches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
/**
* External dependencies
*/
import jsdom from 'jsdom-jscore';
import jsdomLevel1Core from 'jsdom-jscore/lib/jsdom/level1/core';
import jsdom from 'jsdom-jscore-rn';
import jsdomLevel1Core from 'jsdom-jscore-rn/lib/jsdom/level1/core';

// must be called to initialize jsdom before patching prototypes
jsdom.html( '', null, null );
Expand Down
Loading