Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow web side's lead to add indexToSelect to onReplace #1024

Merged
merged 1 commit into from
May 24, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented May 23, 2019

Fixes #1023

This PR updates the onReplace dispatcher call to pass indexToSelect to it.

Relevant change on the web side:
WordPress/gutenberg@eddd4fc#diff-86ce6d1930888d88a252e7d2ee38334aR712 from the RichText: stabilize onSplit PR.

To test:

  1. Place the caret at the end of a middle item on the list of the demo content
  2. Tap an "Enter" to create a new list item
  3. Tap "Enter" again to split the list
  4. A new paragraph block should be created in-between the split list and the caret placed in it

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest requested a review from SergioEstevao May 23, 2019 15:24
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fix! Working like a charm! 🚢

@hypest hypest added the bugfix label May 24, 2019
@hypest hypest added this to the v1.6 milestone May 24, 2019
@hypest hypest merged commit b33e6bd into develop May 24, 2019
@hypest hypest deleted the issue/1023-focus-paragraph-on-list-split branch May 24, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: caret ends up in new list on list split instead of new paragraph
2 participants