-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contain and retain GB on rotation #9030
Merged
Merged
Commits on Jan 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 98940eb - Browse repository at this point
Copy the full SHA 98940ebView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for d502dc6 - Browse repository at this point
Copy the full SHA d502dc6View commit details
Commits on Jan 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1a8f5f2 - Browse repository at this point
Copy the full SHA 1a8f5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5cb4c - Browse repository at this point
Copy the full SHA 1f5cb4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62efc23 - Browse repository at this point
Copy the full SHA 62efc23View commit details
Commits on Jan 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 13da084 - Browse repository at this point
Copy the full SHA 13da084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5772623 - Browse repository at this point
Copy the full SHA 5772623View commit details -
Don't re-finish GB init if recreating Activity
GutenbergEditorFragment has been recreated but the GB container hasn't so, no need to re-send content, etc. Essentially, we do let the system kill and recreate the fragments, and only let the parent continue with the "setContent()" logic if the GB container was in fact re-initialized. That handles the cases of the system killing the activities (like when "Don't keep activities" developer setting is enabled, and when rotating the device.
Configuration menu - View commit details
-
Copy full SHA for 4cf21c8 - Browse repository at this point
Copy the full SHA 4cf21c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22fd283 - Browse repository at this point
Copy the full SHA 22fd283View commit details
Commits on Jan 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8461ee7 - Browse repository at this point
Copy the full SHA 8461ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f856965 - Browse repository at this point
Copy the full SHA f856965View commit details
Commits on Jan 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0935d65 - Browse repository at this point
Copy the full SHA 0935d65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 031de3f - Browse repository at this point
Copy the full SHA 031de3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1beff4 - Browse repository at this point
Copy the full SHA c1beff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dfbeae - Browse repository at this point
Copy the full SHA 9dfbeaeView commit details
Commits on Feb 1, 2019
-
Access the retained container directly
It's retained so, accessing it via the fragment manager creates some gaps on its availability. The fragment is still alive and active but not attached yet so, the manager doesn't offer it.
3Configuration menu - View commit details
-
Copy full SHA for 0e2237f - Browse repository at this point
Copy the full SHA 0e2237fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 487fe2b - Browse repository at this point
Copy the full SHA 487fe2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b852d4 - Browse repository at this point
Copy the full SHA 2b852d4View commit details
Commits on Feb 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 53c1fcf - Browse repository at this point
Copy the full SHA 53c1fcfView commit details
Commits on Feb 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7013eaa - Browse repository at this point
Copy the full SHA 7013eaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6dee6a - Browse repository at this point
Copy the full SHA c6dee6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea19f07 - Browse repository at this point
Copy the full SHA ea19f07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 251e109 - Browse repository at this point
Copy the full SHA 251e109View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0044147 - Browse repository at this point
Copy the full SHA 0044147View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec9f0a8 - Browse repository at this point
Copy the full SHA ec9f0a8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.