-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gutenberg-mobile ref to enable edit button over image-block #11557
Conversation
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great! Thank you @ashiagr 🙏
Thanks a lot for reviewing @etoledom ! @oguzkocer is it ok to merge this PR to develop? CircleCI tests are failing but don't think it is because of this PR. Btw I can't merge because required statuses must pass before merging. |
@ashiagr I restarted the build and everything seems to be fine. When this happens next time in a PR and you think it's false failure, consider following the steps below:
When I get pinged I'll be following the same steps.
Yeap and you definitely shouldn't. Please ping us on Slack if you need any urgent help to merge a PR. We made the connected tests optional and the other tasks very rarely fail, so this shouldn't cause any friction. Separate from this PR, while trying to figure out what might be wrong with this PR I checked the linked Gutenberg PRs. The process might be different in Gutenberg and if it is, please feel free to follow the process there, but otherwise I suggest not merging a PR after making changes to it. (except for some edge cases*) In general, we should give the reviewers a chance to re-check the PR after a new commit and that includes especially merges from another PR. * An example edge case would be a change to a Hope it helps! |
Thanks for a detailed explanation @oguzkocer , it definitely helps 🙏. I'll try to follow your advice. Just one question:
Earlier I could rerun CircleCI workflow, I used to try it when tests failed but recently I noticed I am not authorised to do so. What's the recommended way to trigger CircleCI restart? |
You're right @oguzkocer , didn't realise when I got logged out of CircleCI. Everything sorted now. Thank you! @etoledom , can we finally merge this PR? |
Thanks for confirming to merge on slack @etoledom ! |
Fixes #11147
This PR updates
gutenberg-mobile
ref to enable edit button over image-block.Corresponding
gutenberg-mobile
PR: wordpress-mobile/gutenberg-mobile#2062.PR submission checklist:
RELEASE-NOTES.txt
if necessary.