Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on double rotation with modal #10383

Merged
merged 9 commits into from
Mar 25, 2020
Merged

Fix crash on double rotation with modal #10383

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
527de03
Destroy activity reference when gb container fragment is detached
mkevins Aug 13, 2019
ed6206c
Update gbm submodule reference
mkevins Aug 14, 2019
5af4aad
Update gutenberg-mobile reference
mkevins Dec 11, 2019
71a1382
Merge branch 'develop' into try/fix-double-rotation-modal-crash
mkevins Dec 11, 2019
8a2f5ba
Merge branch 'develop' into try/fix-double-rotation-modal-crash
cameronvoell Mar 13, 2020
66abc30
Merge branch 'develop' into try/fix-double-rotation-modal-crash
cameronvoell Mar 24, 2020
13a1b28
Updating gutenberg ref
cameronvoell Mar 25, 2020
a50e0ce
Updating gutenberg ref
cameronvoell Mar 25, 2020
cb147d9
Updating gutenberg ref
cameronvoell Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergContainerFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,13 @@ public void onResume() {
mWPAndroidGlueCode.onResume(this, getActivity());
}

@Override
public void onDetach() {
super.onDetach();

mWPAndroidGlueCode.onDetach(getActivity());
}

@Override
public void onDestroy() {
super.onDestroy();
Expand Down
2 changes: 1 addition & 1 deletion libs/gutenberg-mobile
Open in desktop
Submodule gutenberg-mobile updated 11 files
+1 −1 .circleci/config.yml
+15 −11 README.md
+2 −0 RELEASE-NOTES.txt
+1 −1 gutenberg
+1 −0 package.json
+0 −2 react-native-aztec/android/src/main/java/org/wordpress/mobile/ReactNativeAztec/ReactAztecText.java
+3 −2 react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
+7 −1 ...droid/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java
+5 −0 react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
+5 −0 react-native-gutenberg-bridge/index.js
+28 −0 yarn.lock