-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to payment status #709
base: trunk
Are you sure you want to change the base?
Conversation
PCP-582
@@ -109,7 +109,7 @@ protected function handle_authorization_status( | |||
case AuthorizationStatus::CREATED: | |||
case AuthorizationStatus::PENDING: | |||
$wc_order->update_status( | |||
'on-hold', | |||
apply_filters( 'ppcp_authorized_order_status', 'on-hold' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the filters in this plugin use woocommerce_paypal_payments_
prefix.
We check statuses in several places. Something could be broken here if someone changes the status via this filter. Maybe in some of these places we simply need to add this filter. woocommerce-paypal-payments/modules/ppcp-wc-gateway/src/WCGatewayModule.php Lines 247 to 257 in 8118da2
woocommerce-paypal-payments/modules/ppcp-webhooks/src/Handler/CheckoutOrderCompleted.php Lines 139 to 142 in 8118da2
woocommerce-paypal-payments/modules/ppcp-webhooks/src/Handler/CheckoutOrderApproved.php Lines 196 to 206 in 8118da2
woocommerce-paypal-payments/modules/ppcp-webhooks/src/Handler/PaymentCaptureCompleted.php Lines 122 to 131 in 8118da2
woocommerce-paypal-payments/modules/ppcp-vaulting/src/PaymentTokenChecker.php Lines 113 to 115 in 125150a
woocommerce-paypal-payments/modules/ppcp-wc-gateway/src/Processor/AuthorizedPaymentsProcessor.php Lines 181 to 188 in 635236c
|
Issue: PCP-582
Ticket:
Slack Thread:
Description
Adds a filter for the status of authorized payments.
Steps to Test
Documentation
Changelog Entry