Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Pay: Fix the incorrect popup triggering (2645) #2414

Conversation

danieldudzic
Copy link
Collaborator

Description

This PR fixes the incorrect Google Pay behavior upon user button click. Our async transaction info fetching was being interpreted by browsers as 'non-user initiated' resulting in a "To make this purchase using Google Pay, open this website in a browser app, such as Chrome or Safari" error.

This PR adds transaction info preloading, resolving the issue.

Steps to Test

  1. Activate Google Pay.
  2. Add a product to the cart.
  3. Try to pay with Google Pay, make sure you get the correct screen, and confirm that you can complete the order.

Screenshots

Before After
Google Pay 2 Google_Pay

@Dinamiko Dinamiko merged commit 2e44e11 into trunk Jul 23, 2024
8 checks passed
@Dinamiko Dinamiko deleted the PCP-2645-when-selecting-google-pay-as-a-payment-option-in-safari-a-developer-error-is-displayed branch July 23, 2024 10:57
@Dinamiko Dinamiko added the bug Something isn't working label Aug 7, 2024
@Dinamiko Dinamiko added this to the 2.8.3 milestone Aug 7, 2024
@Dinamiko Dinamiko mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants