PayPal js files loaded on non PayPal pages (3341) #2411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Some plugin assets (JS files) were loaded on WooCommerce settings pages that did not require them.
Checks
cart-paylater-block-inserter.js
enqueue_block_editor_assets
settings.js
← optimized171
of the commitFurther Cleanup:
This PR also does minor cleanup of the relevant PHP class
trailingslashit()
calls in theregister()
methodenqueue()
method from bool to void - it's only used as an action callback