Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping callback compatibility with WC Name Your Price plugin #2402

Conversation

Narek13
Copy link
Collaborator

@Narek13 Narek13 commented Jul 9, 2024

PR Description

The problem is solved by adding compatibility layer for the WC Name Your Price plugin

Issue Description

When shipping callback is enabled, express payments for Name Your Price products may fail.

Steps to Reproduce

  1. Set up a product with Name Your Price (don’t set any min/max prices)
  2. Enable the shipping callback in PayPal Payments and enable the buttons e.g. on Classic Cart page
  3. Add the NYP product to your cart with your own price
  4. Visit the Cart page
  5. Click the PayPal button
  6. Confirm payment from the popup window
  7. Observe buyer is redirected to order confirmation page
  8. But there is an error stating that the payment provider declined the payment
  9. User gets another chance to pay by clicking the Pay button
  10. In the PCP log files, you will observe a patch attempt for a zero amo

@Narek13 Narek13 self-assigned this Jul 9, 2024
…oblem-with-name-your-price-plugin

# Conflicts:
#	modules/ppcp-button/src/Helper/WooCommerceOrderCreator.php
@Dinamiko Dinamiko merged commit a3bd284 into trunk Jul 23, 2024
7 checks passed
@Dinamiko Dinamiko deleted the PCP-3342-shipping-callback-compatibility-problem-with-name-your-price-plugin branch July 23, 2024 12:27
@Dinamiko Dinamiko added the bug Something isn't working label Aug 7, 2024
@Dinamiko Dinamiko added this to the 2.8.3 milestone Aug 7, 2024
@Dinamiko Dinamiko mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants