POC: Receive button properties from the Checkout Block #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexflorisca, just to let you know that we have created this PR for working on #47899 POC integration, for now it only checks if I noticed that is not currently possible to set "Large" size because there is a button size limitation on PayPal. cc. @InpsydeNiklas |
…hen-adding-to-cart-1-product-if-pcp-is-activated 2.8.1-alpha1 - Server 500 error when adding to cart >1 product if PCP is activated (3300)
…heckout-fields-layout-in-ryan-flow AXO: Fix the layout with the Twenty Twenty-Four theme (3249)
…r-guest-user-on-short-checkout-greyed-out-and-payment-not-possible-when-fastlane-enabled AXO: Disable Fastlane for subscription products (3295)
Make the outline of the payment button visible
“White with outline” correctly displays the outline
…-order-error-in-package-tracking-metabox-breaking-wc-order Don't render tracking metaBox if can't retrieve PayPal order (3289)
…eak-orders-screen-when-there-is-an-exception-for-package-tracking
…ackage-build-leftovers Run eslint autofix and remove introduced package build leftovers
…dually-option-in-paypal-vaulting Sold individually automatically disabled after changing from PayPal subscription to PayPal vaulting and adding product more then one time to cart (3362)
Resolve merge conflict due to new JS code format
…with-filter-for-the-bn-code Create a constant for the BN code (3021)
…astlane-enabled-and-we-add-product-to-cart-and-navigate-to-checkout AXO: Replace the init hook with wp_loaded to avoid getting 'called too early' errors (3359)
…art-button-preview-on-standard-payments-tab Wrong string in smart button preview on Standard Payments tab (3360)
…untry-eligibility
…rd-processing-country-eligibility Extend Advanced Card Processing country eligibility (3348)
…uring-callback-not-updated-correctly Shipping methods during callback not updated correctly (3305)
Release 2.8.2-rc1
…mart Button Stylings may be controlled by the Checkout block configuration
…mmerce-checkout-block' of github.com:woocommerce/woocommerce-paypal-payments into PCP-3202-retrieve-button-styling-properties-from-woo-commerce-checkout-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some exploratory work to explore how we can synchronise the express payment button styles better to create more cohesiveness in the Express Checkout block. This PR is a part of POC: Pass properties to Express Checkout buttons. It updates the express payment method to receive
buttonAttributesproperty from the checkout block, and override theheightproperty if available.Testing instructions
try/poc-express-checkout-button-stylesbranchPlease note that is not possible to set "Large" size as PayPal only allows values between 25px and 55px: