-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Payment Methods as separate payment gateways (3258, 3259) #2163
Open
pedrosilva-pt
wants to merge
16
commits into
trunk
Choose a base branch
from
PCP-153-optionally-present-alternative-payment-methods-as-separate-payment-gateway
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Alternative Payment Methods as separate payment gateways (3258, 3259) #2163
pedrosilva-pt
wants to merge
16
commits into
trunk
from
PCP-153-optionally-present-alternative-payment-methods-as-separate-payment-gateway
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-methods-as-separate-payment-gateway # Conflicts: # modules/ppcp-wc-gateway/services.php
…ent-methods-as-separate-payment-gateway
…ent-methods-as-separate-payment-gateway
…ent-methods-as-separate-payment-gateway
…ent-methods-as-separate-payment-gateway
danieldudzic
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a setting for selecting separated Alternative Payment Methods and ensures it can process orders. Also ensures WC checkout form is validated before starting the payment process.
Introduces WC payment gateway
StandardButtonGateway.php
for handling all separated APMs. It also includes APMs in validation logic and payment process.Acceptance Criteria
Setting for selecting separated Alternative Payment Methods
A merchant wants to show the iDEAL button inside of the regular PayPal gateway, as per default. So, it wasn’t selected in the Disable Alternative Payment Methods setting. However, the merchant wants all other payment buttons not to appear. Except for Venmo, this should be a separate payment gateway on the Checkout page, independently of the PayPal gateway.
New Venmo payment gateway tab.
When customer selects United States, Venmo payment gateway is shown.
When customer selects Netherlands, iDeal payment gateway is shown in PayPal buttons.
SEPA payment gateway process payment
Ensure WC checkout form validation before starting the payment process