Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS error in single product when free trial subscription in the cart (2783) #2098

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

JS error in single product when free trial subscription in the cart (2783) #2098

wants to merge 1 commit into from

Conversation

pedrosilva-pt
Copy link
Collaborator

PR Description

This PR resolves the Javascript error when either enable-funding or disable-funding is not set.

It also isolates the simulate cart processing in CartSimulator class.

Issue Description

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'split')
    at xt (Utils.js:26:19)
    at SingleProductBootstap.js:268:37
    at SimulateCart.js:41:38

JS error in single product when free trial subscription in the cart.

Steps To Reproduce

  • Enable WC Subscriptions plugin
  • Enable Vaulting and Subscriptions mode Vaulting
  • Create a free trial subscription product
  • Add a free trial product to the cart
  • Visit a single product page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinamiko Dinamiko Dinamiko approved these changes

@danieldudzic danieldudzic Awaiting requested review from danieldudzic

@Narek13 Narek13 Awaiting requested review from Narek13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pedrosilva-pt @Dinamiko