-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quick setup methods for recommended payment gateways #164
base: trunk
Are you sure you want to change the base?
Conversation
*/ | ||
public function get_setup_help_text() { | ||
return sprintf( | ||
__( 'Your API details can be obtained from your <a href="%s">Paypal developer account</a>, and your Merchant Id from your <a href="%s">Paypal Business account</a>. Don’t have a Paypal account? <a href="%s">Create one.</a>', 'woocommerce-paypal-payments' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuatf: Not formally reviewing this, but please keep in mind that the correct capitalization is "PayPal" (not "Paypal") 😸.
Adding this here for reference, as I already mentioned it in Slack:
|
da28c99
to
44e5672
Compare
Thanks for taking a look at this, @louwie17! The SlotFill component names and package itself were recently changed. Updated this in 44e5672. This worked for me as-is after rebuilding the assets and should be fine, but if it doesn't work still, it may require a |
Thanks for the quick fix @joshuatf, it tested well this time 👍 |
Just a note here that the Slot names seemed to have changed again. |
2abf7a0
to
0a2beed
Compare
@joelclimbsthings @louwie17 This has been rebased and had a significant amount of changes. It could use another review to verify things are still working as expected. I would also like a review from someone on @woocommerce/axiom to verify that building the settings from resources does not break anything. |
I tested this on a completely new install:
What do you mean about building the settings from resources? |
@joshuatf Any news on this PR? |
Adds quick setup methods for the payment recommendations setup.
Related PR - woocommerce/woocommerce-admin#7044
Description
This PR SlotFills the payment task in the WooCommerce onboarding task list. In brief, this PR does the following:
ppcp-onboarding
module.needs_setup
check.I apologize for the size of this PR; most if it is boilerplate and the component itself has been copied from WooCommerce Admin with a bit of refactoring.
I tried to follow this repo's conventions as closely as possible, but please let me know if there are changes that would be more in line with the code in this repo.
Steps to test:
plugins/
directory matching the wp.org slug.woocommerce-paypal-payments
npm run build:dev
;git clone https://github.com/woocommerce/woocommerce-admin.git && cd woocommerce-admin && composer install && npm i && npm run build
)./wp-admin/admin.php?page=wc-admin&task=payments
/onboarding/get-params
endpoint to force the manual connection form.Changelog entry
Add SlotFill for WooCommerce Admin onboarding payment task.