New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Swiftlint to 0.41.0 #6956

Draft

joshheald wants to merge 4 commits into trunk from issue/3173-upgrade-swiftlint

Contributor

joshheald commented May 26, 2022 •

edited

Loading

Closes: #3173

Description

Updates SwiftLint so that we can remove the non-inclusive language from the project, and use only_rules instead.

Testing instructions

Lint runs successfully with bundle exec rake lint and on CI.

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.


          Upgrade Swiftlint to 0.47.1

e6287ac

joshheald added the type: task label

joshheald added this to In progress in Continuous Improvements via automation

joshheald added 2 commits

May 26, 2022 16:50


          Use Swiftlint 0.41.0

66ce108

0.47.1 is not yet marked as supported by hound.

0.43.1 is the latest supported version, however, it will not cleanly install.

0.41.0 is the most recent version which will cleanly install.


          Fix MARK: - linting errors

1fffa69

joshheald requested a review from shiki

May 26, 2022 15:54

joshheald changed the title ~~Upgrade Swiftlint to 0.47.1~~ Upgrade Swiftlint to 0.41.0

joshheald added this to the 9.3 milestone

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

joshheald removed the request for review from shiki

May 26, 2022 16:02


          Try with the listed latest supported swiftlint

b6cdc55

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

joshheald mentioned this pull request

Upgrade SwiftLint to 0.41.0 to Allow Inclusive Languages houndci/hound#1825

Open

Collaborator

wpmobilebot commented May 26, 2022

You can test the changes from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr6956-b6cdc55 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

oguzkocer modified the milestones: 9.3, 9.4

oguzkocer modified the milestones: 10.0, 10.1

oguzkocer modified the milestones: 10.1, 10.2, 10.3

oguzkocer modified the milestones: 10.3, 10.4

oguzkocer modified the milestones: 10.4, 10.5

spencertransier modified the milestones: 10.5, 10.6

spencertransier modified the milestones: 10.6, 10.7, 10.8

spencertransier modified the milestones: 10.8, 10.9

spencertransier modified the milestones: 10.9, 11.0

oguzkocer modified the milestones: 11.0 ❄️, 11.1, 11.2

oguzkocer modified the milestones: 11.2, 11.3

oguzkocer modified the milestones: 11.3, 11.4

oguzkocer removed this from the 11.4 ❄️ milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment