Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze: Remove remote feature flag check #13320

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

itsmeichigo
Copy link
Contributor

Closes: #13181

Description

This PR removes the remote feature flag check for Blaze eligibility. The check is now synchronous since we no longer have to check with the remote.

Testing steps

  • Log in to a store eligible for Blaze.
  • Confirm that Blaze entry points in the Hub menu and dashboard are still available.

Screenshots

Dashboard Hub menu

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: technical debt Represents or solves tech debt of the project. feature: Blaze Related to the integration of the Blaze ads platform labels Jul 15, 2024
@itsmeichigo itsmeichigo added this to the 19.6 milestone Jul 15, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 15, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13320-723be99
Version19.5
Bundle IDcom.automattic.alpha.woocommerce
Commit723be99
App Center BuildWooCommerce - Prototype Builds #9996
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pmusolino pmusolino self-assigned this Jul 15, 2024
Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@itsmeichigo itsmeichigo merged commit 1e6a647 into trunk Jul 15, 2024
20 of 22 checks passed
@itsmeichigo itsmeichigo deleted the task/13181-remove-blaze-remote-feature-flag branch July 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Blaze Related to the integration of the Blaze ads platform type: technical debt Represents or solves tech debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Blaze remote feture flag
3 participants