-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HACK week] Product form - Action buttons to mark/remove as favorite #12284
base: trunk
Are you sure you want to change the base?
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected, nice work. I understand everything is local data, but am curious if it's feasible to keep favorites even after logging out. Most users probably expect that to happen, not knowing the technical limitation.
I tried looking into Core to see if there is a built-in feature for this. The closest I found is the "Favorite" feature:
This also affects how products are shown on the site itself, though, and if I understand correctly, this feature we're building is just for product management. In the future if we revisit this feature, I wonder if we can take into account this "Featured" functionality (e.g: by adding "Featured" option in the "Sort by" selector in the app).
Thanks for the review, Hafiz! Marking it as draft to address feedback about using userdefaults in #12287. |
Thanks for the input, @hafizrahman! Yes, I took a look at this before starting work and learned that this feature in core is used to feature the product to the users (customers). Our "Favorite product" feature's goal is to allow merchants to favorite products for easy management. They are different features and our feature will be mobile only (with no backend support from core) at least for now. |
👋 again @hafizrahman, I have revisited this PR and pushed changes to,
Please take another look at the PR when you can. Thank you! |
Sorry, Hafiz! I am marking this PR as a draft until I find time to address the feedback from this child PR. #12287 (comment) |
Part of: #12274
Description
Show action buttons in product form to mark/remove a product as a favorite. We will show favorite products in the product list screen in a future PR.
Changes
Testing instructions
product_detail_mark_as_favorite_tapped
event is trackedproduct_detail_remove_from_favorite_tapped
event is trackedScreenshots
RELEASE-NOTES.txt
if necessary.