Remove propTypes definitions from Reviews By Product

[hritikchaudhary]

Fixes #9522
Fixes woocommerce/woocommerce#42362

Changes in the PR:

Removed propTypes definitions from Reviews By Category.

Testing

Automated Tests

• Changes in this PR are covered by Automated Tests.
  • Unit tests
  • E2E tests

User Facing Testing

• Do not include in the Testing Notes

WooCommerce Visibility

• WooCommerce Core
• Feature plugin
• Experimental

[hritikchaudhary]

Hi @nielslange this PR following ts errors will be flagged:

1. onChange - ProductControl in which this onChange is used is yet to be converted in ts will be converted in Convert index.js to index.tsx and replace propTypes with TypeScript definitions #9537 the error is:

2. noReviewsPlaceholder:
   when i try to convert NoReviewsPlaceholder to a ReactElementLike or it asks me for mandatory properties, if i provide them then it stops showing This block lists reviews for a selected product. %s doesn't have any reviews yet, but they will show up here when it does. if product have no reviews.

If there are any other approach/method i can try please let me know I'll update the code.

I tried resolving them but no luck ended up in a rabbit hole and changed multiple files but this goes to other module as well so I reverted my changes

[nielslange]

onChange - ProductControl in which this onChange is used is yet to be converted in ts will be converted in #9537

Thanks for reaching out, @hritikchaudhary, and letting me know that you'll address that TS error in #9537.

If there are any other approach/method i can try please let me know I'll update the code.

I tried resolving them but no luck ended up in a rabbit hole and changed multiple files but this goes to other module as well so I reverted my changes

@gigitux Do you see how to address the second TS error @hritikchaudhary mentioned in #9692 (comment)? I looked into it, but could only came up with the following fix.

• Changing noReviewsPlaceholder={ NoReviewsPlaceholder } to noReviewsPlaceholder={ <NoReviewsPlaceholder /> } in assets/js/blocks/reviews/reviews-by-product/block.tsx.
• Changing getProduct: () => void; to getProduct?: () => void; in assets/js/blocks/reviews/reviews-by-product/types.ts.

However, this fix does not look elegant to me. I'm excited to hearing your thoughts on this.

[nielslange]

Thanks for working on this, @hritikchaudhary. Below, I left some feedback regarding moving inline TS definitions into the corresponding component. I wonder what your thoughts are on that.

[hritikchaudhary]

• Changing noReviewsPlaceholder={ NoReviewsPlaceholder } to noReviewsPlaceholder={ <NoReviewsPlaceholder /> } in assets/js/blocks/reviews/reviews-by-product/block.tsx.
• Changing getProduct: () => void; to getProduct?: () => void; in assets/js/blocks/reviews/reviews-by-product/types.ts.

I tried this yesterday, but it gives a different error in ErrorPlaceholder of no-reviews-placeholder, as it is expecting ErrorPlaceholderProps and gives the following error
Type '{ className: string; error: ErrorObject; isLoading: boolean; onRetry: (() => void) | undefined; }' is not assignable to type 'ErrorPlaceholderProps' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties. Types of property 'onRetry' are incompatible. Type '(() => void) | undefined' is not assignable to type '() => void'. Type 'undefined' is not assignable to type '() => void'.ts(2375)

[gigitux]

onChange - ProductControl in which this onChange is used is yet to be converted in ts will be converted in #9537

Thanks for reaching out, @hritikchaudhary, and letting me know that you'll address that TS error in #9537.

If there are any other approach/method i can try please let me know I'll update the code.
I tried resolving them but no luck ended up in a rabbit hole and changed multiple files but this goes to other module as well so I reverted my changes

@gigitux Do you see how to address the second TS error @hritikchaudhary mentioned in #9692 (comment)? I looked into it, but could only came up with the following fix.

• Changing noReviewsPlaceholder={ NoReviewsPlaceholder } to noReviewsPlaceholder={ <NoReviewsPlaceholder /> } in assets/js/blocks/reviews/reviews-by-product/block.tsx.
• Changing getProduct: () => void; to getProduct?: () => void; in assets/js/blocks/reviews/reviews-by-product/types.ts.

However, this fix does not look elegant to me. I'm excited to hearing your thoughts on this.

For the noReviewsPlaceholder error, you can create a d.ts file for the withProduct HOC. I created a POC PR to show it hritikchaudhary#1. In general, I would say to keep this solution as just temporary since the best approach is to convert the HOC to Typescript as well.

[hritikchaudhary]

For the noReviewsPlaceholder error, you can create a d.ts file for the withProduct HOC. I created a POC PR to show it hritikchaudhary#1. In general, I would say to keep this solution as just temporary since the best approach is to convert the HOC to Typescript as well.

Hi Luigi, thanks for the feedback, I'll look into it and push the improved changes soon..

[hritikchaudhary]

Closed this PR due to numerous merge conflicts and #9522 is already fixed in different PR raised #10249 to fix woocommerce/woocommerce#42362