This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move the usage of Notices from @wordpress/components from frontend to editor (Filter by Rating) #8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -1.15 kB (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
changed the title
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
sunyatasattva
approved these changes
Feb 20, 2023
|
E2E tests failing seem unrelated. Bypassing and merging. |
kmanijak
deleted the
misc/dont-use-notice-from-wordpress-components-on-fe
branch
dinhtungdu
added
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two versions of a library used in the repo:
This PR is a step towards that goal. (Issue: #8452).
Testing
Automated Tests
User Facing Testing
wp-admin/edit.php?post_type=product&page=product-reviews, mark all the reviews and Bulk Actions -> Move to Trash -> Apply (it can be reverted*)Expected: Notice is displayed
Expected: There's no Filter by Rating and no Notice.
to revert moving the reviews to trash go to
http://store.local/wp-admin/edit.php?post_type=product&page=product-reviews&comment_status=trash&paged=1, mark all the reviews and Bulk Actions -> Restore -> ApplyDo not include in the Testing Notes
WooCommerce Visibility
No changelog on purpose