This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use the @wordpress/components instead of wordpress-components while in editor #8432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdpress-components
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
kmanijak
added
block: cart
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +20 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Feb 17, 2023
|
E2E tests failing seem unrelated. Bypassing and merging. |
dinhtungdu
added
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two versions of a library used in the repo:
@wordpress-components- dedicated to use in the editorwordpress-components- dedicated to use in the frontend. However the library itself is not intended to be used in the frontend, hence the movement to remove such dependency.This PR is a step towards that goal. (Issue: #8452)
The editor blocks:
were using
PlaceholderandButtonfromwordpress-componentsinstead of@wordpress/components. It's aboutNoExpressPaymentMethodsPlaceholdercomponent, which means it was used only in the state when merchant hasn't had any express payment methods configured.Question:
is-primarystyles being overwritten by:
I don't think that's expected and I see other buttons have explicit styles (e.g. white text on a black background). That's not the part of this PR to fix this, but if any of the reviewers is able to confirm the expected result I can apply the fix or at least create an issue.Screenshots
There should be no visual regression of the blocks in editor.
Editor
Testing
User Facing Testing
Prerequisites:
Expected:
wp-admin/admin.php?page=wc-settings&tab=checkoutpage.WooCommerce Visibility
Skipping Changelog on purpose