This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add default currency value for Storybook #8332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +935 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
This is fixed. |
Aljullu
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Confirming it fixes the issue, thanks @roykho! It looks like this happened because when the component was loaded in the Story Book, it didn't have a currency by default.
I'm not sure about fixing it in the components itself instead of fixing it in the story, though. 🤔 If we do expect all currencies to have minorUnit, I don't think we need to add a guard in the component code. Instead, we could fix it in the story control setting defaultValue: currencies.USD,. What do you think?
|
@Aljullu - Yeah I agree. Good catch. I just pushed up the changes. |
roykho
changed the title
|
Sorry I just saw this now. Just to let you folks know, there was already a PR open for this here. I'm not sure why the GitHub interface didn't pick it up. We were discussing with @thealexandrelara some type issues within the story, and I kind of deprioritized it. Not sure if we should continue the work on the Storybook default there, and perhaps leave this PR as adding a default currency, if we want. |
|
Ah ok, since a lot of conversation has been had in your other PR I think any changes to fix this should be done there to prevent future confusions. So I will close this one. |
|
Sorry @roykho for not catching this earlier! I hope the work on Storybook was anyways somehow instructive and propaedeutic to your knowledge of the repo 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
can't access property "minorUnit", currency is not definederror on the ProductPrice story.Fixes #8145
User Facing Testing
npm run storybookand open up the Storybook page.Changelog