This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization] Update the default content in patterns #11997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
albarin
added
type: enhancement
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
|
Hey @jarekmorawski! I've added you as well as a reviewer of the copy updates in this PR.
Thanks! 🙌 |
nefeline
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Greak work here @albarin ! These are my test results:
- ✅ Banner (woocommerce-blocks/banner) OK
- ❓ Featured Category Focus (woocommerce-blocks/featured-category-focus) : it has two different copies for the same pattern: do we know which one is correct?
- ✅ Featured Category Triple (woocommerce-blocks/featured-category-triple) OK
- ✅ Hero Product 3 Split (woocommerce-blocks/hero-product-3-split) OK
- ❓ Hero Product Chessboard (woocommerce-blocks/hero-product-chessboard) copy OK. Design is different
- ✅ Hero Product Split (woocommerce-blocks/hero-product-split) OK
- ✅ Just Arrived Full Hero (woocommerce-blocks/just-arrived-full-hero) OK
- ✅ Product Collection 4 Columns (woocommerce-blocks/product-collection-4-columns) - renamed from 1:1 image 4-column products row OK
- ✅ Product Collection 5 Columns (woocommerce-blocks/product-collection-5-columns) OK
- ✅ Social: Follow us on social media (woocommerce-blocks/social-follow-us-in-social-media) OK
- ✅ Alternating Image and Text (woocommerce-blocks/alt-image-and-text) OK
- ✅ Testimonials 3 Columns (woocommerce-blocks/testimonials-3-columns) OK
- ✅ Testimonials Single (woocommerce-blocks/testimonials-single) OK
- ✅ Featured Category Cover Image (woocommerce-blocks/featured-category-cover-image) OK
Default content for products
I noticed that for all patterns displaying real products, we didn't make any changes to the default placeholder content or image for the dummy products.
On a separate PR, what do you think about selecting 6 default images and content to assign to the dummy products? I would suggest using the ones selected for the Product Gallery pattern, since it already displays 6 products exactly, but could be any in the images used in patterns with products (e.g. Product Collection 5 Columns)
Tagging @jarekmorawski here to confirm, since this is a design decision :) TLDR: we have multiple patterns featuring products, (e.g. Product Collection 5 Columns, Product Collection 4 Columns, Product Gallery, etc.), and each one of these patterns has different images/content assigned to them on Figma, but in reality, we only need six as those are real auto-generated products (created only if the store owner doesn't have any products added to their store yet) that will always be displayed whenever these patterns are inserted in the editor.
@albarin To implement this, we would have to update the ProductUpdater class by:
- Making sure the titles of those products match the designs (by updating them here: )
- Making sure the images of those products match the designs (by updating the logic in the ProductUpdater class: )
WDYT?
| @@ -63,9 +63,15 @@ | |||
| "content": { | |||
| "titles": [ | |||
| { | |||
| "default": "Announcing our newest collection", | |||
| "default": "Black and white high-quality prints", | |||
There was a problem hiding this comment.
I see this pattern has two different copies on Figma:
Do we have a confirmation of what copy is the correct one?
There was a problem hiding this comment.
I don't know why we have two versions. I'll ask.
There was a problem hiding this comment.
The current implementation of this pattern has the second picture, which is why I chose the Black and white high-quality prints copy. Not sure about the two versions though.
| @@ -171,31 +177,37 @@ | |||
| "content": { | |||
| "titles": [ | |||
| { | |||
| "default": "Quality Materials", | |||
| "default": "Inspired living spaces", | |||
There was a problem hiding this comment.
Our implementation for this pattern differs from the design, with two sections missing.
Design:
Implemented:
Do you happen to remember if there was any previous discussion that resulted in this change @albarin ?
There was a problem hiding this comment.
Oh, I see you already pinged Jarek about this #11997 (comment), cool! Let's wait for his response! 🙌
There was a problem hiding this comment.
Do you happen to remember if there was any previous discussion that resulted in this change @albarin?
Yes, this was discussed with Veronica and Tom in this conversation p1698926001899609/1698918388.375659-slack-C053716F2H2
nefeline
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
I'm going ahead and hitting the approve button as I can confirm the copy was correctly updated for all patterns: depending on the outcome of the discussion with Jarek, for potential changes in design on the Hero Product Chessboard pattern and the default placeholder content for dummy products, let's open separate PRs. 👍
|
Thanks for your review @nefeline, I'm merging this PR. |
No, it should match the design. Otherwise, the pattern becomes more tricky to work with regarding imagery and layout.
Yes, please! Note that all titles should be aligned to the left, like in the designs. FlPl7fHaGv9mpu8Nfl0joH-fi-158_32452
Not sure why it was removed, but if that was the decision, I'll update the Figma file. As for the copy, I'd swap it for |
|
@jarekmorawski @nefeline This is the follow-up PR solving the latest Jarek's feeback. |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the copy of some patterns and makes some small pattern tweaks and improvements.
Fixes #11875
Why
To ensure it matches with the new copy provided by design.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog