This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Button: always enqueue the store #11858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
gigitux
changed the title
|
Size Change: 0 B Total Size: 1.6 MB ℹ️ View Unchanged
|
kmanijak
approved these changes
Nov 21, 2023
wavvves
pushed a commit
that referenced
this pull request
Nov 21, 2023
wavvves
added a commit
that referenced
this pull request
Nov 21, 2023
4 tasks
|
Cherry-picked into #11841 🍒 |
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
* Updated changelog and added testing instructions * Updated changelog. * Updated versions. * Updated tested up to * Updated tested up to * Uploaded testing zip * Removed #11287 from testing instructions * Added testing instructions and changelog for #11858 * Updated testing zip * Testing instructions for #11862 and #11860 * Updated testing zip * New testing zip with #11872 🍒 * Updated versions to 11.7.0-dev * Updated composer.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes woocommerce/woocommerce#41115
Why
When the "product-button-interactivity-frontend.js" is loaded, the script expects to have access to the
statevariable. Currently, we create thestatevariable only if the product exists. This is not right, because, in the case of the Product Collection block, the script is loaded even if any product is rendered on the page (#11857).Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog